Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix DataPipeline resolution in Task #212

Merged
merged 4 commits into from
Apr 14, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Apr 14, 2021

What does this PR do?

Fixes #211

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #212 (3ed7b82) into master (6185bda) will increase coverage by 0.23%.
The diff coverage is 93.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   86.33%   86.56%   +0.23%     
==========================================
  Files          57       57              
  Lines        2759     2747      -12     
==========================================
- Hits         2382     2378       -4     
+ Misses        377      369       -8     
Flag Coverage Δ
unittests 86.56% <93.10%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/vision/embedding/model.py 74.35% <ø> (+0.54%) ⬆️
flash/core/model.py 96.22% <92.85%> (+4.01%) ⬆️
flash/core/classification.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6185bda...3ed7b82. Read the comment docs.

@ethanwharris ethanwharris marked this pull request as ready for review April 14, 2021 13:48
@tchaton tchaton merged commit 14502b0 into master Apr 14, 2021
@tchaton tchaton deleted the bugfix/classification_postprocess branch April 14, 2021 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassificationPostprocess being overwritten - never called
2 participants