Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Data Pipeline V2: Refactor Deserializer into Serve Input #1013

Merged
merged 16 commits into from
Dec 2, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Dec 1, 2021

What does this PR do?

Fixes #916

This change is temporary until we get merge the ServeInput and add serve_load_sample directly to the Input base class.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot added the has conflicts label Dec 1, 2021
@mergify mergify bot removed the has conflicts label Dec 1, 2021
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #1013 (d496941) into master (9fac5e2) will increase coverage by 0.05%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
+ Coverage   85.28%   85.33%   +0.05%     
==========================================
  Files         254      254              
  Lines       13655    13662       +7     
==========================================
+ Hits        11645    11659      +14     
+ Misses       2010     2003       -7     
Flag Coverage Δ
unittests 85.33% <96.42%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/batch.py 92.10% <ø> (ø)
flash/core/data/io/input_base.py 92.72% <93.33%> (+6.26%) ⬆️
flash/audio/speech_recognition/data.py 73.28% <100.00%> (+0.18%) ⬆️
flash/core/data/data_pipeline.py 96.92% <100.00%> (+0.01%) ⬆️
flash/core/data/process.py 62.06% <100.00%> (-4.60%) ⬇️
flash/core/model.py 86.57% <100.00%> (ø)
flash/image/data.py 82.66% <100.00%> (ø)
flash/image/segmentation/data.py 82.32% <100.00%> (ø)
flash/tabular/data.py 95.10% <100.00%> (ø)
flash/text/classification/data.py 97.01% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fac5e2...d496941. Read the comment docs.

@mergify mergify bot added the has conflicts label Dec 1, 2021
@mergify mergify bot removed the has conflicts label Dec 2, 2021
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😃 I guess the existing deserializers should be renamed to end in ServeInput and will also need to extend serve input rather than deserializer

flash/core/data/io/input_base.py Outdated Show resolved Hide resolved
flash/core/model.py Show resolved Hide resolved
flash/image/data.py Show resolved Hide resolved
flash/core/data/process.py Show resolved Hide resolved
@tchaton tchaton merged commit 1b55dc5 into master Dec 2, 2021
@tchaton tchaton deleted the issue_916_refactor_deserializer_into_input branch December 2, 2021 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Deserializer to be a DataSource / Input
2 participants