Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[wip] Refactor Deserializer to be a DataSource / Input #981

Closed
wants to merge 2 commits into from

Conversation

ananyahjha93
Copy link
Contributor

What does this PR do?

Fixes #916

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #981 (18c8c96) into master (073166e) will decrease coverage by 0.07%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #981      +/-   ##
==========================================
- Coverage   88.26%   88.19%   -0.08%     
==========================================
  Files         250      250              
  Lines       13155    13184      +29     
==========================================
+ Hits        11611    11627      +16     
- Misses       1544     1557      +13     
Flag Coverage Δ
unittests 88.19% <80.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/process.py 68.75% <80.00%> (+2.08%) ⬆️
flash/audio/speech_recognition/data.py 89.65% <0.00%> (-2.72%) ⬇️
flash/text/classification/model.py 91.83% <0.00%> (-0.76%) ⬇️
flash/text/classification/data.py 96.89% <0.00%> (-0.52%) ⬇️
flash/tabular/forecasting/data.py 94.82% <0.00%> (-0.26%) ⬇️
flash/tabular/data.py 95.00% <0.00%> (ø)
flash/core/utilities/types.py 100.00% <0.00%> (ø)
flash/tabular/forecasting/cli.py 100.00% <0.00%> (ø)
flash/audio/speech_recognition/cli.py 100.00% <0.00%> (ø)
flash/core/data/io/input.py 94.49% <0.00%> (+0.01%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073166e...18c8c96. Read the comment docs.

@ethanwharris
Copy link
Collaborator

Adressed by #1013

@mergify mergify bot added the has conflicts label Dec 2, 2021
@Borda Borda deleted the refactor/deserializer branch April 27, 2022 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Deserializer to be a DataSource / Input
2 participants