fix for python 3.6 where DLFCN was removed#84
Closed
veprbl wants to merge 1 commit intoPySlurm:masterfrom
veprbl:dlfcn
Closed
fix for python 3.6 where DLFCN was removed#84veprbl wants to merge 1 commit intoPySlurm:masterfrom veprbl:dlfcn
veprbl wants to merge 1 commit intoPySlurm:masterfrom
veprbl:dlfcn
Conversation
8 tasks
Member
|
Hi. I would be more inclined to use |
Author
|
When preparing this PR I was looking to minimize possible breakage. I now did a small test to see if additionally importing ctypes will take more time and didn't see any significant overhead, so, I guess, that ctypes can be very well used instead, especially if it has better compatibility. |
Member
|
I updated |
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.