Skip to content

fix for python 3.6 where DLFCN was removed#84

Closed
veprbl wants to merge 1 commit intoPySlurm:masterfrom
veprbl:dlfcn
Closed

fix for python 3.6 where DLFCN was removed#84
veprbl wants to merge 1 commit intoPySlurm:masterfrom
veprbl:dlfcn

Conversation

@veprbl
Copy link

@veprbl veprbl commented Jul 13, 2017

No description provided.

@giovtorres
Copy link
Member

Hi. I would be more inclined to use ctypes.RTLD_GLOBAL instead of the os.RTLD_GLOBAL module. This way, it would be supported from python 2.6 through 3.6. This is what I have in the dev branch and hasn't made it yet into master. Thoughts?

@veprbl
Copy link
Author

veprbl commented Jul 14, 2017

When preparing this PR I was looking to minimize possible breakage. I now did a small test to see if additionally importing ctypes will take more time and didn't see any significant overhead, so, I guess, that ctypes can be very well used instead, especially if it has better compatibility.

@giovtorres
Copy link
Member

I updated __init__.py in 9004364. Give it a try. Thanks.

@veprbl
Copy link
Author

veprbl commented Jul 15, 2017

Thank you!

@veprbl veprbl closed this Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants