Fix building for musl libc (alpine linux)

[alex]

This fixes PyO3/pyo3#1109

I tried just include this flag in args, but for some reason that didn't work. Passing in the env does work.

[kngwyu]

Thanks!

As I commented on PyO3/pyo3#1109, it's better if we have any comment that explains why this works for musl. A short description or just a URL is OK, though.

[alex]

@kngwyu rust-lang/rust#44991 is where I got the idea. https://doc.rust-lang.org/reference/linkage.html#static-and-dynamic-c-runtimes has a bit more detail.

[davidhewitt]

Probably a comment referring to rust-lang/rust#59302 is enough?

Also, please add a CHANGELOG entry. I only just remembered to update the CHANGELOG for the 0.11.2 release, so you might want to rebase on master and then add an Unreleased section at the top.

[alex]

@davidhewitt done! thanks much.

[davidhewitt]

Thanks very much, just a few final nits from me!

[davidhewitt]

LGTM. Thanks for the sleuthing w.r.t RUSTFLAGS. If it's okay, I'll wait for merging just incase anyone else has any extra comments e.g. from the maturin discussion.

[alex]

Sure, that's fine.

[alex]

No particular urgency, but how long do you want to wait for feedback :-)

[davidhewitt]

I was hoping to wait for the maturin discussion to move forward, but as nobody seems to have responded on there let's merge this to keep things moving forward. I guess you'll be wanting this as a patch release?

[alex]

Thanks! And yeah, unfortuntely there's no way to do point pep517 at a VCS dependency :-/

[davidhewitt]

0.11.3 released. Thanks again for all your recent fixes to this project!

[alex]

Of course! More than happy to contribute. Thanks for pyo# I'm extremely excited for getting to ship this to a whole bunch of users

…

On Mon, Aug 24, 2020 at 5:53 PM David Hewitt ***@***.***> wrote: 0.11.3 released. Thanks again for all your recent fixes to this project! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#80 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBBCI6BPQ7BNZF3KHKLSCLONXANCNFSM4QBGTK7A> .

-- All that is necessary for evil to succeed is for good people to do nothing.

[davidhewitt]

👍 btw when cryptography releases with some Rust code in it do feel free to open a PR to add it to the pyo3 README section listing example projects!