Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include py.typed when packaging. #338

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Include py.typed when packaging. #338

merged 2 commits into from
Jun 1, 2023

Conversation

clokep
Copy link
Contributor

@clokep clokep commented May 31, 2023

#186 added a py.typed file, but this isn't packaged automatically so other packages (which depend on setuptools-rust) are unable to take advantage of the type hints in it.

I ran python -m build before and after this change:

diff -u <(tar -tf dist/setuptools-rust-1.6.0.tar.gz) <(tar -tf dist-new/setuptools-rust-1.6.0.tar.gz)
--- /dev/fd/11	2023-05-31 09:15:26
+++ /dev/fd/12	2023-05-31 09:15:26
@@ -13,6 +13,7 @@
 setuptools-rust-1.6.0/setuptools_rust/clean.py
 setuptools-rust-1.6.0/setuptools_rust/command.py
 setuptools-rust-1.6.0/setuptools_rust/extension.py
+setuptools-rust-1.6.0/setuptools_rust/py.typed
 setuptools-rust-1.6.0/setuptools_rust/rustc_info.py
 setuptools-rust-1.6.0/setuptools_rust/setuptools_ext.py
 setuptools-rust-1.6.0/setuptools_rust/version.py

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please add a Packaging CHANGELOG entry?

@clokep
Copy link
Contributor Author

clokep commented May 31, 2023

Thanks! Could you please add a Packaging CHANGELOG entry?

Done!

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants