-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate PyArray
contructors to Bound
API (Part 3)
#419
Conversation
7dd1d4d
to
de69ccc
Compare
Out of curiosity, is this the last change needed before it would be possible to make a release compatible with pyo3 0.21? Is there any timeline for such a release? |
There is still 2 or 3 PRs left to migrate everything:
I can't say anything on a release schedule. Depending on the project you need this for, you could also try using cargo's patch to build against |
I think we are still on the beta version and I am not completely sure whether Cargo will unify this with a dependency on the release version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for cosmetics.
Please also bump the dependency to the final version of PyO3 0.21 while fixing those up.
Following #418
This finalizes the migration of
PyArray
constructors to theBound
API. This migrates withPyArray::{from_iter, from_array, from_vec}
, alongside withIntoPyArray
andToPyArrray
which they use under the hood. I think with this all constructors should be migrated.