use PyErr::write_unraisable when panicking
#5496
Merged
+102
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #5496 will not alter performanceComparing Summary
|
Icxolu
approved these changes
Nov 2, 2025
| /// # Safety | ||
| /// | ||
| /// - `ptr` must be a valid pointer to a Python object | ||
| /// - `ptr` must be a valid pointer to a Python object (or null, which will cause a panic) |
Contributor
There was a problem hiding this comment.
It might make sense to (also?) put this in a "Panics" heading as is done for the Py variants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tidies up the panic pathway of
Bound,BorrowedandPyconstructors from FFI pointer:#[cold]PyErr::write_unraisablerather thanPyErr_Print.Overall a minor change but I think is more correct.