fix garbage collection in inheritance cases #4563
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2024
Draft
|
Aside from benchmarks CI failure (which is solved separately in #4591) I think this is now ready for merge. Does anyone want to review before I do so? I'm keen to merge and get on with back porting this for 0.22.4. |
|
Will proceed with merge (and backporting) 🙈 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Ok will get #4599 merged and backported first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking at GC code recently in #4479 I had a nagging feeling that inheritance might also be a problem with
__traverse__.I finally had some time to follow up on that thought today, and it turns out that indeed in cases of
#[pyclass(extends = ...)]then we are currently not traversing the base class (or calling its'__clear__function).This PR fixes that, by modifying the generated code for both
__traverse__and__clear__to call the base type's function.Both of the new tests currently fail on
main. I think this probably should be patched as 0.22.4, as this is just a straight-up memory leak for all inheritance cases otherwise :(