Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run codecov job using PR head #4488

Merged
merged 2 commits into from
Aug 25, 2024
Merged

ci: run codecov job using PR head #4488

merged 2 commits into from
Aug 25, 2024

Conversation

davidhewitt
Copy link
Member

Variant of #4483 which should hopefully avoid the security flaws (thanks @alex).

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Aug 24, 2024
@davidhewitt
Copy link
Member Author

Looks like this is working as intended.

I've gone a step further and decided to run coverage for all OSes on PR, to match main and get the fairest diff. I've also disabled the coverage runs on the merge queue, as they won't add any value there and this'll speed up merges ever so slightly.

@davidhewitt davidhewitt added this pull request to the merge queue Aug 25, 2024
Merged via the queue into PyO3:main with commit 3d46a3a Aug 25, 2024
43 checks passed
@davidhewitt davidhewitt deleted the codecov-commit branch August 25, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidhewitt