Remove the BoundObject impl for &Bound, use Borrowed instead
#4487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChayimFriedman2
force-pushed
the
remove-impl-boundobject-for-ref-bound
branch
from
c726f8c
to
2bc8b06
Compare
LilyFoote
approved these changes
Aug 24, 2024
ChayimFriedman2
force-pushed
the
remove-impl-boundobject-for-ref-bound
branch
from
2bc8b06
to
e67b728
Compare
For rationale see PyO3#4467. I chose to make `bound_object_sealed::Sealed` unsafe instead of `BoundObject` so that users won't see the `# Safety` section, as it's not relevant for them.
ChayimFriedman2
force-pushed
the
remove-impl-boundobject-for-ref-bound
branch
from
e67b728
to
809f0d5
Compare
davidhewitt
reviewed
Aug 25, 2024
newsfragments/4487.changed.md
Outdated
There was a problem hiding this comment.
No need for this as BoundObject is new in this release; users will never see this change.
davidhewitt
approved these changes
Aug 25, 2024
| /// # Safety | ||
| /// | ||
| /// Type must be layout-compatible with `*mut ffi::PyObject`. | ||
| pub unsafe trait Sealed {} |
There was a problem hiding this comment.
Yep I'm happy with the unsafe guarantee going here where users will never see it 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For rationale see #4467.
I chose to make
bound_object_sealed::Sealedunsafe instead ofBoundObjectso that users won't see the# Safetysection, as it's not relevant for them.
Closes #4467.