Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reintroduce PyTypeInfo methods #4484

Merged
merged 1 commit into from
Aug 24, 2024
Merged

reintroduce PyTypeInfo methods #4484

merged 1 commit into from
Aug 24, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Aug 24, 2024

No description provided.

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Aug 24, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 24, 2024

CodSpeed Performance Report

Merging #4484 will degrade performances by 10.58%

Comparing Icxolu:typeinfo (09e2372) with main (44c16ec)

Summary

❌ 1 regressions
✅ 75 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main Icxolu:typeinfo Change
❌ not_a_list_via_extract 1.8 µs 2 µs -10.58%

@LilyFoote LilyFoote added this pull request to the merge queue Aug 24, 2024
Merged via the queue into PyO3:main with commit 07da500 Aug 24, 2024
43 of 44 checks passed
@Icxolu Icxolu deleted the typeinfo branch August 24, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyFoote LilyFoote LilyFoote approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Icxolu @LilyFoote