Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing: fix test command #4482

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Contributing: fix test command #4482

merged 1 commit into from
Sep 1, 2024

Conversation

birkenfeld
Copy link
Member

Only "cargo test" does not run Python tests.

@birkenfeld birkenfeld added the CI-skip-changelog Skip checking changelog entry label Aug 24, 2024
Copy link
Contributor

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

Contributing.md Outdated
@@ -110,7 +110,7 @@ You can run these tests yourself with
`nox -s clippy-all`

#### Tests
`cargo test --features full`
`nox -s test`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it potentially worth mentioning both options here? I tend to use cargo test to selectively run the ones I care about (and it's much quicker), though I agree most contributors would benefit from having this recommendation.

Copy link
Member Author

@birkenfeld birkenfeld Aug 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also nox -s test-rust 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But yes, for running a specific test cargo test is probably still best, I'll add a sentence.

Oh, and for adding a hint how to run Rust tests, is there a way to run a specific test from pytests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cd pytests && nox -s test -- -k <test> (the -k switch goes to underlying pytest execution)

Copy link
Member

@davidhewitt davidhewitt Aug 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or nox -f pytests/noxfile.py -s test -- -k <test> to avoid the cd.

Only "cargo test" does not run Python tests.
@birkenfeld
Copy link
Member Author

Updated.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@davidhewitt davidhewitt added this pull request to the merge queue Sep 1, 2024
Merged via the queue into main with commit 9eab260 Sep 1, 2024
43 checks passed
@davidhewitt davidhewitt deleted the contrib-fix branch September 1, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants