Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mention type name in "no constructor defined" message #4481

Merged
merged 1 commit into from
Aug 24, 2024
Merged

mention type name in "no constructor defined" message #4481

merged 1 commit into from
Aug 24, 2024

Conversation

birkenfeld
Copy link
Member

fixes #4470

davidhewitt
davidhewitt approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I think it could use a changed entry in the changelog.

@birkenfeld
Copy link
Member Author

Thanks, didn't know if this was enough to warrant one :)

davidhewitt
davidhewitt approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@davidhewitt davidhewitt added this pull request to the merge queue Aug 24, 2024
Merged via the queue into main with commit ff1b5c4 Aug 24, 2024
43 checks passed
@davidhewitt davidhewitt deleted the fix-4470 branch August 24, 2024 11:37
davidhewitt pushed a commit that referenced this pull request Sep 3, 2024
@birkenfeld @davidhewitt
mention type name in "no constructor defined" message (#4481)
ec0276f 
fixes #4470
davidhewitt pushed a commit that referenced this pull request Sep 3, 2024
@birkenfeld @davidhewitt
mention type name in "no constructor defined" message (#4481)
5d4a155 
fixes #4470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#[new] can silently fail when arguments to the function can't be constructed
2 participants
@birkenfeld @davidhewitt