Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong trait bound IntoPyObject impls for Hash collections #4478

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Aug 23, 2024

No description provided.

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Aug 23, 2024
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the BuildHasher being wrong explains a lot...

@davidhewitt davidhewitt added this pull request to the merge queue Aug 23, 2024
@Icxolu
Copy link
Contributor Author

Icxolu commented Aug 23, 2024

Yeah, the auto deref made the error point to a completely different spot. Only fully qualifying the trait method call made a reasonable error message appear.

Merged via the queue into PyO3:main with commit e068a30 Aug 23, 2024
44 checks passed
@Icxolu Icxolu deleted the fix-hash-intopyobject branch August 23, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants