Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reintroduce PyErr constructors and methods #4475

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Aug 23, 2024

No description provided.

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Aug 23, 2024
Copy link
Contributor

@LilyFoote LilyFoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there, just noticed a couple easy-to-fix issues.

src/err/mod.rs Outdated Show resolved Hide resolved
src/err/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Lily Foote <[email protected]>
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super to me, thanks!

@davidhewitt davidhewitt added this pull request to the merge queue Aug 23, 2024
Merged via the queue into PyO3:main with commit 18bca6e Aug 23, 2024
41 of 43 checks passed
@Icxolu Icxolu deleted the warn branch August 24, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants