ci: swap .python-version file for explicit versions in actions yml #4462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4462 will improve performances by 17.36%Comparing Summary
Benchmarks breakdown
|
|
Will merge immediately to unblock CI. |
davidhewitt
added a commit
that referenced
this pull request
Sep 13, 2024
…4462) * ci: swap .python-version file for explicit versions in actions yml * pin valgrind job to 3.12.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
.python-versionfile in the repo root and adds explicit versions to CI YAML.This is for two reasons:
.python-versioncan mess withpyenvand make it harder to test different Python versions if that's your tool of choice.valgrindjob has a new failure on CPython 3.12.5 which might be an upstream issue (needs investigating / reporting); by pinning to 3.12.4 in the short term we can unblock CI.