Delete iter_dict_nosegv test #4459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would be in favour of just removing this whole test; it dates back to a time long ago when PyO3 had much less test coverage and had a lot more rough edges. |
ngoldbaum
force-pushed
the
dont-skip-test
branch
from
c23588f
to
57fb326
Compare
ngoldbaum
changed the title
ngoldbaum
force-pushed
the
dont-skip-test
branch
from
57fb326
to
0dd39aa
Compare
davidhewitt
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out this test isn't deadlocking, it's just very slow on a debug build of Python. It takes 1.3 s on 3.13.0rc1, 6.31 s on a debug build of 3.13.0rc1, and 14.02 s on a debug free-threaded build. This sort of performance difference is expected I think.
Creating a dict that holds 10 million items also seems like a lot for a test. I don't have context for the original issue this test was added for, but maybe a change to use a dict with fewer items would be OK?