Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding tests for pyclass hygiene cases #4359

Merged
merged 3 commits into from
Jul 17, 2024
Merged

fix: adding tests for pyclass hygiene cases #4359

merged 3 commits into from
Jul 17, 2024

Conversation

Zyell
Copy link
Contributor

@Zyell Zyell commented Jul 17, 2024

This adds the tests for pyclass hygiene mentioned in issue #4358

This is a work in progress. It resolves the struct case with eq implementation and partially resolves the enum cases as outlined in the issue.

fix: updated pyclass heighten check to validate for eq and ord, fixin…
2f83eec 
…g Ok issue in eq implementation.

identified similar issues in Complex enum and tuple enum,  resolved serveral cases, but working on current error coming from traits not being in scope
@Zyell Zyell marked this pull request as draft July 17, 2024 16:46
Icxolu
Icxolu reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@Icxolu Icxolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! I think there are two more cases to fix here

  • fully qualify the clone calls
  • fully qualify the From trait in PyClassInitializer::from

pyo3-macros-backend/src/pyclass.rs Outdated Show resolved Hide resolved
@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Jul 17, 2024
@Zyell Zyell marked this pull request as ready for review July 17, 2024 20:38
Icxolu
Icxolu approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@Icxolu Icxolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks again 🚀

@Icxolu Icxolu enabled auto-merge July 17, 2024 20:58
@Icxolu Icxolu added this pull request to the merge queue Jul 17, 2024
Merged via the queue into PyO3:main with commit c1f524f Jul 17, 2024
42 checks passed
@Zyell Zyell mentioned this pull request Jul 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Icxolu Icxolu Icxolu approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zyell @Icxolu