Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dict.get_item binding to use PyDict_GetItemRef #4355

Merged
merged 18 commits into from
Aug 1, 2024
Merged

Update dict.get_item binding to use PyDict_GetItemRef #4355

merged 18 commits into from
Aug 1, 2024
+106 −5

Commits on Aug 1, 2024

  1. Update dict.get_item binding to use PyDict_GetItemRef 

    Refs PyO3#4265
    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ded4f34 View commit details
    Browse the repository at this point in the history

  2. test: add test for dict.get_item error path

    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    12495df View commit details
    Browse the repository at this point in the history

  3. test: add test for dict.get_item error path

    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    09f87a1 View commit details
    Browse the repository at this point in the history

  4. test: add test for dict.get_item error path

    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1ad7d40 View commit details
    Browse the repository at this point in the history

  5. fix: fix logic error in dict.get_item bindings

    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c82ccf0 View commit details
    Browse the repository at this point in the history

  6. update: apply david's review suggestions for dict.get_item bindings

    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    243385d View commit details
    Browse the repository at this point in the history

  7. update: create ffi::compat to store compatibility shims

    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    cb66f2f View commit details
    Browse the repository at this point in the history

  8. update: move PyDict_GetItemRef bindings to spot in order from dictobj… 

    …ect.h
    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ac5394d View commit details
    Browse the repository at this point in the history

  9. build: fix build warning with --no-default-features

    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ebf9602 View commit details
    Browse the repository at this point in the history

  10. doc: expand release note fragments

    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    49ea2fc View commit details
    Browse the repository at this point in the history

  11. fix: fix clippy warnings

    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    a2e3595 View commit details
    Browse the repository at this point in the history

  12. respond to review comments

    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    3fe8d0b View commit details
    Browse the repository at this point in the history

  13. Apply suggestion from @mejrs

    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    f3df5fe View commit details
    Browse the repository at this point in the history

  14. refactor so cfg is applied to functions

    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c7bda51 View commit details
    Browse the repository at this point in the history

  15. properly set cfgs

    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    9b7cf0f View commit details
    Browse the repository at this point in the history

  16. fix clippy lints

    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    55c7603 View commit details
    Browse the repository at this point in the history

  17. Apply @davidhewitt's suggestion

    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    963f6c2 View commit details
    Browse the repository at this point in the history

  18. deal with upstream deprecation of new_bound

    @ngoldbaum
    ngoldbaum committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    44d1f9e View commit details
    Browse the repository at this point in the history