allow #[pymodule(...)] to accept all relevant #[pyo3(...)] options
#4330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As matter of API style, I like this. Didn't review the impl closely |
davidhewitt
commented
Jul 9, 2024
| @@ -4,8 +4,14 @@ error: `submodule` may only be specified once (it is implicitly always specified | |||
| 4 | mod submod {} | |||
| | ^^^ | |||
|
|
|||
| error[E0433]: failed to resolve: use of undeclared crate or module `submod` | |||
| --> tests/ui/duplicate_pymodule_submodule.rs:4:6 | |||
| error[E0425]: cannot find value `_PYO3_DEF` in module `submod` | |||
There was a problem hiding this comment.
This error looks a bit strange; is the result of the macro failing early with errors and not emitting the complete submodule.
I think changes like #4243 can improve this in future.
Merged
Icxolu
approved these changes
Jul 10, 2024
davidhewitt
added a commit
that referenced
this pull request
Jul 16, 2024
davidhewitt
added a commit
that referenced
this pull request
Jul 16, 2024
davidhewitt
added a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosely a follow-up to #4308, cc @alex
This change makes
#[pymodule]consistent with#[pyfunction]and#[pyclass]in that it now accepts all the module-related#[pyo3(...)]options directly in#[pymodule(...)]e.g.
#[pymodule] #[pyo3(name = "foo")]can now be the shorthand#[pymodule(name = "foo")].While doing this I made a few adjustments to the
#[pymodule]macro implementation to make it more consistent with how the others are implemented. I also updated the docs on#[pymodule]at the same time.