use FFI calls for refcounting on all abi3 versions #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Our benchmarking infra isn't particularly high fidelity, but this change looks like it's within the noise floor for us: https://github.com/pyca/cryptography/actions/runs/9856363207?pr=11232 |
|
👍 cc @mgorny are you willing to test one of the problematic packages with this branch? If so, I'm tempted to merge it for the simplification it brings. |
|
I'll try on rustworkx in a minute. |
|
And confirmed! Without the patch, |
|
Great! In which case if fellow PyO3 maintainers are happy, I propose to merge this and ship as 0.22.2 (maybe also with #4321 when that's done). |
Merged
|
Having heard no concerns, I think let's move ahead with this. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
davidhewitt
added a commit
that referenced
this pull request
Jul 16, 2024
* use FFI calls for refcounting on all abi3 versions * fix implementation on PyPy
davidhewitt
added a commit
that referenced
this pull request
Jul 16, 2024
* use FFI calls for refcounting on all abi3 versions * fix implementation on PyPy
davidhewitt
added a commit
that referenced
this pull request
Jul 17, 2024
* use FFI calls for refcounting on all abi3 versions * fix implementation on PyPy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #4311 (comment)
The idea is that we can mitigate issues around 3.12's immortal objects and wonky CPython assertions by backporting the stable ABI change to use FFI calls for refcounting from 3.12 all the way back to our supported version of 3.8.
cc @alex - you might be interested in this for the possible performance impact on cryptography (though this impact would be felt eventually anyway).