fix deprecation warning for trailing optional on #[setter] functions
#4304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
setter-optional
branch
from
65a8ad3
to
646beb7
Compare
alex
reviewed
Jul 2, 2024
| @@ -228,6 +228,18 @@ impl FnType { | |||
| } | |||
| } | |||
|
|
|||
| pub fn signature_attribute_allowed(&self) -> bool { | |||
There was a problem hiding this comment.
I think it'd be helpful for future us to add a comment explaining why (getter/setter/classattr have fixed signatures with a single arg where Option<> has a specific meaning)
There was a problem hiding this comment.
Good idea, added one, WDYT?
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4292
Basically just don't emit the warning for
setterorgetterfunctions, and adds a test.