Added as_super methods to PyRef and PyRefMut.
#4219
Merged
Commits on May 28, 2024
-
Added
PyRef::as_superandPyRefMut::as_supermethods, including d……ocstrings and tests. The implementation of these methods also required adding `#[repr(transparent)]` to the `PyRef` and `PyRefMut` structs.
-
-
Changed the
AsRef<U>/AsMut<U>impls forPyRefandPyRefMutto…… use the new `as_super` methods. Added the `PyRefMut::downgrade` associated function for converting `&PyRefMut` to `&PyRef`. Updated tests and docstrings to better demonstrate the new functionality.
Commits on Jun 8, 2024
-
Updated
PyRef::as_super,PyRefMut::as_super, and `PyRefMut::downg……rade` to use `.cast()` instead of `as _` pointer casts. Fixed typo.
-
-
Updated
PyRef::as_superandPyRefMut::downgradeto use `ptr_from_……ref` for the initial cast to `*const _` instead of `as _` casts.
-
Added
pyo3::internal_tricks::ptr_from_mutfunction alongside the `p……tr_from_ref` added in PR PyO3#4240. Updated `PyRefMut::as_super` to use this method instead of `as *mut _`.
-
Updated the user guide to recommend
as_superfor accessing the base…… class instead of `as_ref`, and updated the subsequent example/doctest to demonstrate this functionality.
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.