Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement PySetMethods and PyFrozenSetMethods #3694

Merged
merged 4 commits into from
Dec 26, 2023

Conversation

davidhewitt
Copy link
Member

Split out from #3606. These types are very similar so I've paired them together.

@davidhewitt
Copy link
Member Author

Looks like this need #3695 first for the Py_LIMITED_API iterator implementations.

src/types/frozenset.rs Outdated Show resolved Hide resolved
src/types/frozenset.rs Show resolved Hide resolved
src/types/frozenset.rs Show resolved Hide resolved
src/types/frozenset.rs Outdated Show resolved Hide resolved
src/types/set.rs Outdated Show resolved Hide resolved
src/types/set.rs Outdated Show resolved Hide resolved
src/types/set.rs Outdated Show resolved Hide resolved
src/types/set.rs Outdated Show resolved Hide resolved
@davidhewitt
Copy link
Member Author

Thanks for the review; I've actioned all feedback save for the default methods where I'm not entirely sure on the ask.

src/types/set.rs Outdated Show resolved Hide resolved
@adamreichold adamreichold added this pull request to the merge queue Dec 26, 2023
Merged via the queue into PyO3:main with commit 0344921 Dec 26, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants