implement PyDictMethods
#3675
Merged
implement PyDictMethods
#3675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
dict2-try2
branch
from
4e788e7
to
44a279b
Compare
davidhewitt
force-pushed
the
dict2-try2
branch
from
44a279b
to
15d309e
Compare
adamreichold
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #3606
Fairly mechanical. Most interesting things to note here:
PyDictIteratoras a thin wrapper around the newPyDictIterPyBorrowed::from_ptr_uncheckedto skip the null check completely in cases where we can make the assumption that a null would be a Python interpreter bug