hold onto module name properly in PyCFunction::internal_new
#3649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going through the rewrites in #3606, I spotted that there's a slight "oops" in
PyCFunction::internal_new
where we do basicallym.name()?.into_py(py).as_ptr()
to create a dangling pointer. We get away with this at present because.into_py(py)
usesPyString::new
and puts the string into the GIL pool, thus despite the dangling pointer the reference count is still one for the duration we need it.One the pool bandaid comes off, this bit of code segfaults.
Opened as a review separately because I think this is trivially reviewable and mergeable.