-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start adding a performance section to the guide. #3304
Conversation
c743140
to
0ef27bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for kicking this off!
One day it would be nice to remove this performance pitfall. Something to investigate after removing the pool 😄
0ffea41
to
ff78b92
Compare
@davidhewitt I added another subsection on implicit access to GIL token. Please have another look before this is merged. Also do you remember any other topics when wanted to discuss here? I do think I remember that there about four different things we wanted to have here, but I am unable find a list anywhere in the older issues, pull requests or discussions. |
Is dictionary dispatch, i.e. look-up tables based on type object identity, something we want to discuss here or is this too specialized? |
Personally I think that's quite application-specific, but I'm not against having that section if you want to write it. Some other topics I recalled over the day:
We can potentially move these into an issue rather than write them all in this PR? |
Shouldn't this be covered by the "parallelism" section?
Yes, I'd like to limit this PR to the two small sections already written.
Ok, let's include a note in the issue. Certainly not in this PR. |
Sorry for the slow reply - I got a bit sidetracked by the various PRs I have pushed in the last 24h...
Yes, though I think it can't hurt to call it out i.e. "how do I multithread? See parallelism section". More visibility :) |
We discussed this quite often and I though that even if it is only a single thing, just making a start would improve our chances of getting it finished eventually.