Improve derive(FromPyObject) to apply intern! when applicable to get_item #2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbx2
changed the title
davidhewitt
force-pushed
the
improve-derive-frompyobject-apply-intern
branch
from
61e48b4
to
8026f35
Compare
davidhewitt
approved these changes
Jan 15, 2023
bors bot
added a commit
that referenced
this pull request
Jan 15, 2023
2879: Improve derive(FromPyObject) to apply intern! when applicable to get_item r=davidhewitt a=qbx2 This PR adds more `intern!`s to FromPyObject derive macro implementation. This should improve performance when using `#[pyo3(item)]`. Co-authored-by: Sunyeop Lee <[email protected]>
Merged
|
Build failed: |
|
bors retry |
|
Build succeeded: |
qbx2
added a commit
to qbx2/pyo3
that referenced
this pull request
Jan 26, 2023
bors bot
added a commit
that referenced
this pull request
Jan 26, 2023
2919: Fix link for #2879 r=mejrs a=qbx2 Fixes an incorrect link in changelog. Co-authored-by: Sunyeop Lee <[email protected]>
bors bot
added a commit
that referenced
this pull request
Jan 26, 2023
2919: Fix link for #2879 r=mejrs a=qbx2 Fixes an incorrect link in changelog. Co-authored-by: Sunyeop Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more
intern!s to FromPyObject derive macro implementation. This should improve performance when using#[pyo3(item)].