deprecate required argument after Option<T> without signature
#2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
required-after-option
branch
from
5f2383b
to
3440f96
Compare
This was referenced Nov 20, 2022
Closed
davidhewitt
force-pushed
the
required-after-option
branch
from
3440f96
to
6523260
Compare
|
This is now rebased; I would be glad to hear folks' opinions on whether this makes sense to include in 0.18. Overall I like what this does for removing ambiguity, which fits Rust's conventions well, however it may generate a lot of churn for users (see all the adjustments I made to our tests). |
|
If there's no strong opinions either way, I'll merge this later in the week ahead of preparing the 0.18 branch. |
davidhewitt
force-pushed
the
required-after-option
branch
from
6523260
to
8f48d15
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #2702 to make required arguments after
Option<T>arguments require a#[pyo3(signature)]annotation to remove the possible ambiguity on whether the developer actually wanted to have a required option (which is what PyO3 is currently forced to assume).