Update readme for PEP 621 support #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
approved these changes
Jun 7, 2021
Readme.md
Outdated
|
|
||
| maturin supports building through pyproject.toml. To use it, create a `pyproject.toml` next to your `Cargo.toml` with the following content: | ||
| maturin supports building source distributions (sdist) through `pyproject.toml`. To use it, create a `pyproject.toml` next to your `Cargo.toml` with the following content: |
There was a problem hiding this comment.
PEP 517 is more than just source distributions! build e.g. can build a wheel directly by invoking build_wheel with minimal setup and afaik pip has a no isolation mode where it also builds wheels directly (I think pypa/pip#9091 is related). For maturin users this is relevant as they might want to do pip install . or pip wheel ., which only works with a pyproject.toml .
There was a problem hiding this comment.
Right. I was thinking the paragraph was only talking about sdist and pip install/pip wheel usually works with sdist published on PyPI, doesn't work with maturin binary release on GitHub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered