Only use extension name from extra metadata if it contains dot #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
bors bot
added a commit
that referenced
this pull request
Jan 13, 2023
1409: Use module name specified by `[package.metadata.maturin]` r=messense a=messense Reverts #536 It's counterintuitive and cause trouble when user needs to customize the name, we now emit a better error message when the name isn't appropriate for `lib`. Helps with astral-sh/ruff#1816 (comment) Co-authored-by: messense <[email protected]>
bors bot
added a commit
that referenced
this pull request
Jan 13, 2023
1409: Use module name specified by `[package.metadata.maturin]` r=messense a=messense Reverts #536 It's counterintuitive and cause trouble when user needs to customize the name, we now emit a better error message when the name isn't appropriate for `lib`. Helps with astral-sh/ruff#1816 (comment) Co-authored-by: messense <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the following example would work because maturin will use
lib.nameinstead ofpackage.metadata.maturin.nameWith #489 it's broken (example) and it will use
package.metadata.maturin.namefor the extension filename which results inImportErrorat runtime.This PR restore the previous behavior.