Normalize wheel distribution names to match the PyPA spec#2954
Merged
Normalize wheel distribution names to match the PyPA spec#2954
Conversation
This fixes building publishable sdists and wheels for packages where the name contains a period. For example, "asimov.py" is normalized into "asimov_py".
Contributor
There was a problem hiding this comment.
Pull request overview
Updates distribution-name normalization to align with the current PyPA Binary Distribution Format spec so wheels/sdists are publishable when project names contain dots.
Changes:
- Normalize distribution names by collapsing runs of
-_.into_and lowercasing for wheel/sdist filenames and.dist-infonaming. - Update docstring to reflect the PyPA spec and how the normalized name is used.
- Remove the WASI-only build guard that rejected names containing dots (now normalized away).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/metadata.rs |
Adjusts get_distribution_escaped() normalization behavior and updates its documentation accordingly. |
src/build_context.rs |
Removes WASI dot-in-name rejection that is no longer relevant with the new normalization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes building publishable sdists and wheels for packages where the name contains a dot (aka period, aka full stop). For example, asimov.py gets normalized into "asimov_py":
Note some relevant history regarding distribution name normalization:
[^\w\d.]+which preserved dots.pip,setuptools, etc.) didn't actually follow this: instead, they replaced dots with underscores.