Swap outer and inner loops in write_python_part()#2861
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the write_python_part() function by reversing the loop nesting order to perform expensive directory traversal only once instead of once per Python package.
Key Changes:
- Moved directory tree traversal (
WalkBuilder) to the outer loop - Changed the package filtering logic from checking a single package to using
.any()to check against all packages - Reduced the number of directory tree walks from N (number of packages) to 1
messense
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Of the two loops (walking the directory tree and iterating over the python packges), the directory traversal is the more expensive one. It should be the outer loop so we only do it once.