Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes unused code from the PathWriter struct, specifically three methods (venv(), delete_dir(), and write_record()) that have no callers in the codebase. With these methods removed, the record field that tracked file hashes is also no longer needed.
- Removed the
recordfield fromPathWriterstruct - Removed three unused public methods from
PathWriter - Removed hash tracking code from
PathWriter::add_bytes_with_permissions - Removed unused
BridgeModelfrom imports
messense
approved these changes
Nov 12, 2025
messense
pushed a commit
that referenced
this pull request
Nov 19, 2025
The removed methods don't seem to be used anywhere and, with them removed, there is no need to keep track of file hashes for the `PathWriter`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The removed methods don't seem to be used anywhere and, with them removed, there is no need to keep track of file hashes for the
PathWriter.