Skip to content

Upgrade goblin to 0.10#2833

Merged
messense merged 1 commit intoPyO3:mainfrom
messense:goblin-0.10
Nov 8, 2025
Merged

Upgrade goblin to 0.10#2833
messense merged 1 commit intoPyO3:mainfrom
messense:goblin-0.10

Conversation

@messense
Copy link
Copy Markdown
Member

@messense messense commented Nov 8, 2025

No description provided.

@messense messense enabled auto-merge (squash) November 8, 2025 13:33
@messense
Copy link
Copy Markdown
Member Author

messense commented Nov 8, 2025

Requires a MSRV bump to 1.85.0.

@messense messense merged commit bb3d629 into PyO3:main Nov 8, 2025
43 of 45 checks passed
@messense messense deleted the goblin-0.10 branch November 8, 2025 14:06
@MatthijsKok
Copy link
Copy Markdown
Contributor

Requires a MSRV bump to 1.85.0.

@messense Does this mean that the rust-version in Cargo.toml could be bumped to 1.85?
That would imply that we could also upgrade to edition = "2024" :D
I'd like to pick that up if that's the case.

Potentially I would still like to also include parts of #2800
I'm still not 100% confident on which parts of that PR are used for compiling bindings.
Can the code in the tests at least be upgraded?

Appreciate your time :)

messense added a commit that referenced this pull request Nov 9, 2025
messense added a commit that referenced this pull request Nov 9, 2025
Reverts #2833

Accidentally merged due to buggy auto-merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants