Conversation
Add Cygwin to all OS logic and bump `target-lexicon` dependency to 0.13.3 for Cygwin support. In `fun_with_abiflags()` add a special case for cygwin, since `platform.system()` returns something like `"CYGWIN_NT-10.0-26200"` there, and not just `"Cygwin"` alone like with other systems. In `get_platform_tag()` default to something like `"cygwin-x86_64"`, which doesn't match `sysconfig.get_platform()` in upstream Cygwin currently, but is proposed here to make pip happy: https://cygwin.com/pipermail/cygwin-apps/2025-October/044659.html In `write_bindings_module()` use `".abi3.dll"` for abi3 builds, as `importlib.machinery.EXTENSION_SUFFIXES` looks like `['.cpython-39-x86_64-cygwin.dll', '.abi3.dll', '.dll']` on Cygwin. With this, one gets a working maturin when building with `--no-default-features --features cli-completion,scaffolding`. The other features pull in abandoned crates that don't work on Cygwin, like PyO3#1858 Fixes PyO3#2818
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Cygwin to all OS logic and bump
target-lexicondependency to 0.13.3 for Cygwin support.In
fun_with_abiflags()add a special case for cygwin, sinceplatform.system()returns something like"CYGWIN_NT-10.0-26200"there, and not just"Cygwin"alone like with other systems.In
get_platform_tag()default to something like"cygwin-x86_64", which doesn't matchsysconfig.get_platform()in upstream Cygwin currently, but is proposed here to make pip happy:https://cygwin.com/pipermail/cygwin-apps/2025-October/044659.html
In
write_bindings_module()use".abi3.dll"for abi3 builds, asimportlib.machinery.EXTENSION_SUFFIXESlooks like['.cpython-39-x86_64-cygwin.dll', '.abi3.dll', '.dll']on Cygwin.With this, one gets a working maturin when building with
--no-default-features --features cli-completion,scaffolding. The other features pull in abandoned crates that don't work on Cygwin, like #1858Fixes #2818
Co-authored-by: @Kreijstal