Don't add duplicate files #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
force-pushed
the
konsti/dont-readd-files-and-validate
branch
from
4d75d87
to
f34e4ab
Compare
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
The conda test CI setup seems broken, but the regular tests are passing, merging manually |
ManonMarchand
added a commit
to cds-astro/mocpy
that referenced
this pull request
Jul 8, 2024
looks related to PyO3/maturin#2125
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jul 19, 2024
## [1.7.0] - 2024-07-07 * Initial iOS support in [#2101](PyO3/maturin#2102) * Remove old import hook in [#2105](PyO3/maturin#2105), use [maturin-import-hook](https://github.com/PyO3/maturin-import-hook) instead * Bump MSRV to 1.74.0 in [#2108](PyO3/maturin#2108) * Add support for overriding wheel tag with `_PYTHON_HOST_PLATFORM` in [#2122](PyO3/maturin#2122) * Don't add files to an archive more than once [#2125](PyO3/maturin#2125) * Only use base python executable when `MATURIN_PEP517_USE_BASE_PYTHON` is set in [#2134](PyO3/maturin#2134)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a file tracker for writing archives that checks that each path in the archive can't be added more than once. If the same file would be added twice, it's ignored the second time, if a different file would be added, it errors.
Fixes #2066
Fixes #2106