Support uniffi-bindgen in cargo workspaces #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 task
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Mar 18, 2024
https://build.opensuse.org/request/show/1158801 by user mia + anag+factory - Update to 1.5.0 * tutorial: fix abi to match comment gh#PyO3/maturin#1876 * Allow identical VIRTUAL_ENV and CONDA_PREFIX env vars gh#PyO3/maturin#1879 * Upgrade pyo3 to 0.20 gh#PyO3/maturin#1881 * Skip directory when adding license files to wheel gh#PyO3/maturin#1890 * Reject -i python when cross compiling gh#PyO3/maturin#1891 * simplified clear-cache github action gh#PyO3/maturin#1897 * Support uniffi-bindgen in cargo workspaces gh#PyO3/maturin#1909 * Upgrade globlin to 0.8.0 gh#PyO3/maturin#1912 * Update **Note** to [!NOTE] in README gh#PyO3/maturin#1917 * Match dependency readmes gh#PyO3/maturin#1915 * Update some actions version in generate ci cli gh#PyO3/maturin#1916 * Use extension name as library name, instead of h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uniffi suggests using a separate crate for uniffi-bindgen in a multi-crate workspace, https://mozilla.github.io/uniffi-rs/tutorial/foreign_language_bindings.html#multi-crate-workspaces. This workflow is currently not supported in maturin.
This PR expands the
uniffi_bindgen_commandto evaluate if the workspace has a bindgen package, and if so it runs the bindgen command from the root of the workspace. This seems to work correctly in my project https://github.com/Hinton/maturin-repro.Resolves #1905