Improve error message when python fails in develop #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by https://www.youtube.com/live/zepPZ6MFiGs?feature=share&t=648, i wanted to improve the error message when `maturin develop` fails because `python` doesn't work. I unfortunately failed to reproduce the error in the video, but i'm nonetheless confident that this is the correct change: It shouldn't say "The given list of python interpreters is invalid" when you didn't provide any list. iirc the error message comes from a time when i assumed users would provide a list like python3.5 python3.6 python3.7 instead of building for one version per CI job.
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
looks to me like it's a new lint that's broken, the lint doesn't fire on 1.69 and removing the clone results in a "borrow of partially moved value" |
messense
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by https://www.youtube.com/live/zepPZ6MFiGs?feature=share&t=648, i wanted to improve the error message when
maturin developfails becausepythondoesn't work.I unfortunately failed to reproduce the error in the video, but i'm nonetheless confident that this is the correct change: It shouldn't say "The given list of python interpreters is invalid" when you didn't provide any list. iirc the error message comes from a time when i assumed users would provide a list like python3.5 python3.6 python3.7 instead of building for one version per CI job.
I thought about redoing the error system around interpreters but i think just pointing out the faulty interpreter is all a user needs to understand and debug the problem