When determining the python module name, use pyproject.toml project.name over Cargo.toml package.name.
#1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name` over Cargo.toml `package.name`. I propose to change the precedence for determining the module name to consider before pyproject.toml `project.name` over Cargo.toml `package.name`. This came up in ruff (astral-sh/ruff#4397, astral-sh/ruff#4399), where the crate name is `ruff_cli` and the project name is `ruff`. I'm not sure if there are any cases a user would like the crate name over the package name.
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
messense
approved these changes
May 13, 2023
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 21, 2023
https://build.opensuse.org/request/show/1088131 by user mia + dimstar_suse - Update to v0.15.3: * Fix cross-compile to Apple universal2 in the other platform gh#PyO3/maturin#1613 * Remove serde(flatten) to improve error messages gh#PyO3/maturin#1616 * Allow syn 2.0 gh#PyO3/maturin#1617 * describe the need for module-name gh#PyO3/maturin#1604 * Add PEP 517 config_settings support gh#PyO3/maturin#1619 * Keep file mode on Unix gh#PyO3/maturin#1622 - Changes in v0.15.2: * Remove bors gh#PyO3/maturin#1602 * When determining the python module name, use pyproject.toml project.name over Cargo.toml package.name. gh#PyO3/maturin#1608 * Warn on missing python-source contents gh#PyO3/maturin#1607 * Fix rewriting dev-dependencies in sdist gh#PyO3/maturin#1610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to change the precedence for determining the module name to consider before pyproject.toml
project.nameover Cargo.tomlpackage.name. This came up in ruff (astral-sh/ruff#4397, astral-sh/ruff#4399), where the crate name isruff_cliand the project name isruff.I'm not sure if there are any cases a user would like the crate name over the package name.