Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completing type hints for python files #1421

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Completing type hints for python files #1421

merged 2 commits into from
Jan 19, 2023

Conversation

ischaojie
Copy link
Contributor

@ischaojie ischaojie commented Jan 19, 2023 •
edited
Loading

Add mypy config and complete type hints for Python files.

The result:

➜  maturin git:(type-hints) mypy maturin
Success: no issues found in 3 source files

There is no need to write changelog, I think.

@netlify
Copy link

netlify bot commented Jan 19, 2023 •
edited
Loading

✅ Deploy Preview for maturin-guide ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2cb36f0
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/63c9168d5c051a0008cf16ec
😎 Deploy Preview https://deploy-preview-1421--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ischaojie ischaojie changed the title Completing type hints for python files [WIP] Completing type hints for python files Jan 19, 2023
@messense
Copy link
Member

messense commented Jan 19, 2023 •
edited
Loading

Thanks! Maybe we should also add mypy check to CI in .github/workflows/lint.yml?

@ischaojie
Copy link
Contributor Author

Thanks! Maybe we should also add mypy check to CI in .github/workflows/lint.yml?

I will add it later.

@ischaojie ischaojie changed the title [WIP] Completing type hints for python files Completing type hints for python files Jan 19, 2023
messense
messense approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks again!

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 19, 2023

Build succeeded:

@bors bors bot merged commit c276141 into PyO3:main Jan 19, 2023
@ischaojie ischaojie deleted the type-hints branch January 19, 2023 13:51
@messense messense mentioned this pull request May 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messense messense messense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ischaojie @messense