-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignore_git_ignore
flag to build options
#1253
Conversation
…re ignored by `.gitignore` files
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
I don't believe this is the way to go. Excluding files via For sdist we already have |
I totally agree with the current default behavior to excludes files listed in ignore files, and the added flag defaults to
Are you suggesting to add that to maturin? [tool.maturin]
include = []
exclude = [] I could try to implement that. Should we keep the |
Yes
We should first deprecate it and print a warning when it appears in configuration, we can then remove |
1255: Add `[tool.maturin.include]` and `[tool.maturin.exclude]` r=messense a=mbrobbel Based on the discussion in #1253, this is another attempt to allow users to override ignore files in Python modules by adding `[tool.maturin.include]` and `[tool.maturin.exclude]` similar to [Poetry](https://python-poetry.org/docs/pyproject/#include-and-exclude). This deprecates `[tool.maturin.sdist-include]`. After some feedback on this approach, I'll add: - [x] Documentation updates - [x] Integration tests Closes #1253 Co-authored-by: Matthijs Brobbel <[email protected]>
1255: Add `[tool.maturin.include]` and `[tool.maturin.exclude]` r=messense a=mbrobbel Based on the discussion in #1253, this is another attempt to allow users to override ignore files in Python modules by adding `[tool.maturin.include]` and `[tool.maturin.exclude]` similar to [Poetry](https://python-poetry.org/docs/pyproject/#include-and-exclude). This deprecates `[tool.maturin.sdist-include]`. After some feedback on this approach, I'll add: - [x] Documentation updates - [x] Integration tests Closes #1253 Co-authored-by: Matthijs Brobbel <[email protected]>
This can be set to include files that are ignored by
.gitignore
files. This was added in #695.This may be helpful when Python modules are generated as part of a build. The module should be included in the wheel, but not in the git repo which is why it's in the
.gitignore
file.