-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: added separate requirement file for torch #599
Conversation
@cako can you check that this is doing what you suggested 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrava87 I changed --extra-index-url
to --index-url
in the requirements-torch.txt file. This ensures that only one index (the pytorch one) is used. However, it means that all requirements must be already installed. Torch is the last one to be installed so this should be fine.
Alright! Let me give it a try. I assume you mean that if I run the pip install command with requirements-torch.txt after that with requirements.txt, the only extra package that should be installed is torch (otherwise any of the other will come from this index instead of the official PyPI?) |
@cako I finally got some time to go back to this.. I tried the following:
and from the latter command I get:
I think this looks good to go, do you agree? |
@cako checking that you saw this.. if you agree, I would like to merge this PR? |
Closes #597 by adding a
requirements-torch.txt
file that installs PyTorch from a specific index.We have also simplified the GA installation process removing unneeded
if [ -f requirements.txt ]; then pip install -r requirements-dev.txt; fi
, simply installing all dependencies as follows: