Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor MFX carriers #280

Merged
merged 9 commits into from
Nov 12, 2024
Merged

refactor MFX carriers #280

merged 9 commits into from
Nov 12, 2024

Conversation

rickwierenga
Copy link
Member

@rickwierenga
Copy link
Member Author

most of the diff is just renaming things

@rickwierenga
Copy link
Member Author

rickwierenga commented Oct 16, 2024

  • expanded ResourceHolder (formerly ResourceHolderMixin, see Machine no longer a Resource, ResourceHolder is a Resource #281) to include a property for the child resource
  • removed CarrierSite, replaced with ResourceHolder
  • Carriers now store the sites in a dict instead of a list
  • renamed PlateCarrierSite to PlateHolder
  • ResourceStack and Plate are not longer ResourceHolders, they just use get_child_location directly
  • rename create_homogeneous_carrier_sites to create_homogeneous_resources, parameters site_size_{x,y} to resource_size_{x,y}
  • rename create_carrier_sites to create_resources
  • directly initialize MFXCarrier with sites rather than having CarrierSite in between

@BioCam
Copy link
Contributor

BioCam commented Nov 7, 2024

Going through the changes I couldn't see how the replacement of PlateCarrierSite to PlateHolder maintains the pedestal_z_height logic from PlateCarrierSite?

@rickwierenga
Copy link
Member Author

PlateCarrierSite was simply renamed into PlateHolder, the implementation should be equivalent

@rickwierenga rickwierenga merged commit c868115 into main Nov 12, 2024
7 checks passed
rickwierenga added a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants