Skip to content

Add support for PEP 563 (#356)#374

Merged
sigmavirus24 merged 2 commits intoPyCQA:masterfrom
joernheissler:pep-563
Dec 22, 2018
Merged

Add support for PEP 563 (#356)#374
sigmavirus24 merged 2 commits intoPyCQA:masterfrom
joernheissler:pep-563

Conversation

@joernheissler
Copy link
Contributor

@joernheissler joernheissler commented Oct 25, 2018

If a module imports annotations from __future__, postpone the evaluation
of annotations like it is done for annotation strings.

Closes #356

@joernheissler
Copy link
Contributor Author

Why does a "nightly" use cpython version "3.7.0a4+"? :-(
Should 3.7 alphas and betas be supported? Or can the "nightly" be upgraded to a more recent python version?

@sigmavirus24
Copy link
Member

@joernheissler we don't control what Travis CI packages as "nightly". I suspect to use a more recent nightly we'd need to discern how to get Travis to give that to us.

@asottile
Copy link
Member

@joernheissler "nightly" for trusty is the last version that supports libssl1.0.0 -- if you want actual nightly you'll need to use dist: xenial. Here's some more information: https://github.com/deadsnakes/travis-ci-python3.7-example#travis-ci-python37-example

@joernheissler
Copy link
Contributor Author

"update 2018-10-15: sudo: required is no longer necessary" is the good news. Let me try that.

@asottile
Copy link
Member

you'll have to remove sudo: false (it's the default afaik) for some reason. travis is weird 🤷‍♂️

@joernheissler
Copy link
Contributor Author

Thanks @asottile, but more trouble as you can see on #379 :-(

@asottile
Copy link
Member

If you switch to matrix you can just turn on xenial for 3.7 / nightly: example

the python3.6 env there is using the default (trusty) dist, where as the 3.7 job is using xenial

@joernheissler
Copy link
Contributor Author

This PR now includes #369 and #379 to make Travis happy. I hope it's fine to do it this way.

@sprt
Copy link

sprt commented Nov 24, 2018

Hey, could this be merged?

@karolyi
Copy link

karolyi commented Nov 28, 2018

voting + 1 for merging this, as, python3.7 spreads more and more over time.

@sigmavirus24
Copy link
Member

Hey, could this be merged?

There's a merge conflict which should probably be resolved before we merge it or otherwise

@joernheissler
Copy link
Contributor Author

@sigmavirus24, I'm happy to fix any merge conflicts, but I guess #369 needs to be merged first.

@senciucserban
Copy link

Any news on this?

@nmatthews-asapp
Copy link

Any updates?

Jörn Heissler added 2 commits December 21, 2018 07:45
If a module imports annotations from __future__, postpone the evaluation
of annotations like it is done for annotation strings.
@joernheissler
Copy link
Contributor Author

I rebased this PR and #379.

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m

@sigmavirus24 sigmavirus24 merged commit 6ee966d into PyCQA:master Dec 22, 2018
jstasiak added a commit to jstasiak/kotlang that referenced this pull request Mar 17, 2019
The issue with unquoted forward references in annotations has been
resolved in PyCQA/pyflakes#374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants