-
Notifications
You must be signed in to change notification settings - Fork 187
Refactor - split to modules, add parser tests, update readme #200
Changes from 13 commits
18959c0
190b0c2
0c11410
1f21307
100cd80
0d7678d
f9eb3c5
1c88e4d
ccd9a73
f4ac91a
a7b0d83
7337fa2
bb32c92
deffd33
cab6da3
dcff6aa
74e68b7
76d7ced
1d6c00b
807e79f
62610d6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
-r requirements/docs.txt | ||
-r requirements/tests.txt | ||
-r requirements/runtime.txt |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
pytest==2.7.3 | ||
pytest-pep8 | ||
mock | ||
tox | ||
tox | ||
pathlib | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,9 @@ | |
from setuptools import setup | ||
|
||
|
||
with open(os.path.join('src', 'pydocstyle.py')) as f: | ||
this_dir = os.path.dirname(__file__) | ||
|
||
with open(os.path.join(this_dir, 'src', 'pydocstyle', 'utils.py')) as f: | ||
for line in f: | ||
if line.startswith('__version__'): | ||
version = eval(line.split('=')[-1]) | ||
|
@@ -27,12 +29,13 @@ | |
'License :: OSI Approved :: MIT License', | ||
], | ||
keywords='pydocstyle, PEP 257, pep257, PEP 8, pep8, docstrings', | ||
packages=('pydocstyle',), | ||
py_modules=('main',), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are you packaging main? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The point of this is to allow to run There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Have you investigated how this is actually installed on a person's computer though? I think this might not do exactly what you want. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll do some experiments to make sure. |
||
package_dir={'': 'src'}, | ||
py_modules=['pydocstyle'], | ||
entry_points={ | ||
'console_scripts': [ | ||
'pydocstyle = pydocstyle:main', | ||
'pep257 = pydocstyle:main_pep257', | ||
'pydocstyle = pydocstyle.cli:main', | ||
'pep257 = pydocstyle.cli:main_pep257', | ||
], | ||
}, | ||
) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
#! /usr/bin/env python | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this file in the right place? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See my comment in |
||
"""Static analysis tool for checking docstring conventions and style. | ||
|
||
The repository is located at: | ||
https://github.com/PyCQA/pydocstyle | ||
|
||
""" | ||
|
||
|
||
__all__ = () | ||
|
||
|
||
def main(): | ||
from pydocstyle import cli | ||
cli.main() | ||
|
||
|
||
if __name__ == '__main__': | ||
main() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I have a quibble with this file. Is tox a test dependency and the rest are dependencies enumerated in tox, or are these test dependencies and tox is a different kind of requirement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separated to
tests.txt
andtest_env.txt
.