E306 false positive

[mlococo]

If I create demo.py with the following contents:

def the_funk():
    1 + 1
    definitely_not_a_function = 1
    return definitely_not_a_function + 1

And run pycodestyle demo.py, I get: bug.py:3:5: E306 expected 1 blank line before a nested definition, found 0. I believe E306 is intended to apply to nested function definitions, but this does not contain a nested function definition.

[sigmavirus24]

What version of pycodstyle are you running? What version of Python? How did you install pycodestyle?

[mlococo]

• Installed via virtualenv.
• venv/bin/pycodestyle --version -> 2.3.0
• venv/bin/python --version -> Python 2.7.12+

[mlococo]

But it also happens when installed globally via pip:

• sudo pip install --upgrade pycodestyle
• which pycodestyle -> /usr/local/bin/pycodestyle
• pycodestyle --version -> 2.3.0
• pycodestyle demo.py -> E306 output.

[tomhamiltonstubber]

Also with python3.5

[samuelcolvin]

Same with python 3.5. Kind of amazing this got as far as being released. 😕.

[sigmavirus24]

Kind of amazing this got as far as being released.

@samuelcolvin if you want better quality, why not pay for it? No one is paid to work on this tool and it's entirely made during people's free time.

[samuelcolvin]

These things happen I know. Not complaining, just commenting. Thanks a lot for pycodestyle @sigmavirus24.

[sigmavirus24]

Not complaining, just commenting.

Those kinds of comments are demoralizing and not welcome on this project.

[sigmavirus24]

This has already been fixed on master. I've added extra tests in #620. master will be released later today.

[mlococo]

For my part, I'm neither surprised nor bothered that bugs happen. I reported because I know enough about this project to get that far in triage, but wasn't able to quickly get as far as a patch with test. Thanks for your work maintaining this project, I know it's a huge commitment compared to the kind of drive-by bug reports I'm doing here.

[sigmavirus24]

No worries @mlococo. Cheers! 🎉

[sigmavirus24]

And 2.3.1 was released with this bug fix.