-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken test with flake8>=3.9.1 #171
Comments
I suspect we didn't cut a new release that includes the updates to our test suite yet @jparise ? |
Our usage of ... but that doesn't explain the error above, which is for the tagged 0.11.1 release. Is there something backwards-incompatible about flake8's 3.9.1's "extended ignore" implementation? |
I believe our tests mock out things that are internal to Flake8, which I've never liked but it hasn't caused too much trouble. I think the change I made caused those half-mocked things to not have all the detail needed |
6d62db8 is (I believe) what would fix things |
Was broken when bumping flake8 to a version newer than 3.9.0, because their tests "mock out things that are internal to Flake8". PyCQA/pep8-naming#171
I believe this was fixed in the last release. Can you confirm, @mweinelt? |
Yes, LGTM. Thanks! |
After upgrading to flake>=3.9.1 the following test failure came up.
Seems related to this change: PyCQA/flake8#1317
The text was updated successfully, but these errors were encountered: