Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile black: missing split_on_trailing_comma=True #2137

Closed
wants to merge 1 commit into from
Closed

Fix profile black: missing split_on_trailing_comma=True #2137

wants to merge 1 commit into from

Conversation

janosh
Copy link

@janosh janosh commented May 20, 2023

@johnthagen
Copy link

I think this is probably the right change to make, but I wanted to advocate that I personally find the current behavior optimal due to editors being able to automatically remove imports and not wanting to leave imports that might otherwise be able to be folded only a single line exploded and consuming vertical space. I personally see imports in a different class (mostly boilerplate) differently than what the black comma rule was more intended for.

But, at the same time I can see the argument to simply be consistent everywhere.

Thankfully the split-on-trailing-comma configuration still exists as an override.

@janosh
Copy link
Author

janosh commented Jul 3, 2023

@johnthagen @timothycrosley Would be great to get a final merge/reject decision here.

@janosh janosh closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants